Region GC#105
Open
kulisak12 wants to merge 15 commits into
Open
Conversation
xFrednet
reviewed
Jun 13, 2026
|
|
||
| /* Create artificial local references to the bridges. */ | ||
| static int | ||
| region_list_add_local_refs(_PyRegionObject *root) { |
Collaborator
There was a problem hiding this comment.
This looks correct. Where do you remove this RC and LRC that you've added here? I can't see it in this commit
Author
There was a problem hiding this comment.
In gc_collect_region_tree. It is not a part of this commit.
https://github.com/kulisak12/cpython/blob/22db1e57fda903be66e75d88c6ba57c7073a5e64/Python/gc.c#L2123
Collaborator
|
For now, I only checked the last commit (based) on the description. I plan to look at the rest later. The fact that this PR is this small is super impressive and a testament for how well you understood the whole thing and wired it up! I'm looking forward to reviewing it :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check the last commit in particular, I still don't understand the write barrier enough 😅